Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mb_str_split() not supported in PHP 7.3 #34

Open
Eruantron opened this issue Sep 28, 2023 · 2 comments
Open

mb_str_split() not supported in PHP 7.3 #34

Eruantron opened this issue Sep 28, 2023 · 2 comments

Comments

@Eruantron
Copy link

The library officially provides support for PHP 7.3 and later. However, I encountered an error when using PHP 7.3.

In deepl-php/src/GlossaryEntries.php, the function mb_str_split() is utilized, but it is only compatible with PHP 7.4 and newer versions.

@daniel-jones-deepl
Copy link
Member

daniel-jones-deepl commented Oct 4, 2023

Hi @Eruantron, thanks for creating this issue, good catch. I'm surprised we didn't catch this earlier, because we test using PHP 7.3.

We have to look into how we could fix this, but it may be too much effort. Additionally, we are planning to drop support for PHP 7.3 beginning next year, because official support for PHP 7.3 ended almost two years ago.

@Eruantron
Copy link
Author

Thanks for the feedback. I already thought it doesn't make sense to rewrite it for PHP 7.3. I've postponed the PHP migration for too long anyway, and now I have another reason for the revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants