[PROF-10235] Add new metadata fields to elf symbol upload #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gandem
approved these changes
Aug 9, 2024
| GNUBuildID string `json:"gnu_build_id"` | ||
| GoBuildID string `json:"go_build_id"` | ||
| FileHash string `json:"file_hash"` | ||
| Platform string `json:"platform"` |
There was a problem hiding this comment.
Is the removal of the Platform field expected?
There was a problem hiding this comment.
Yes, platform is not used on backend side (I also removed it from datdog-ci).
|
Side note the linter is complaining for line length 😢 |
Add symbol_source,origin,origin_version and filename. Remove platform since it's not used on backend side.
nsavoire
force-pushed
the
nsavoire/add_symbols_metadata
branch
from
8e0eacb
to
f2fda8a
Compare
Fixed. This 100 chars limit is annoying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add symbol_source, origin, origin_version and filename to elf symbol uploads.
Remove platform since it's not used on backend side.