Capture manager should check shutdown before attempting to record captures #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeHahn
reviewed
Apr 2, 2024
lading/src/captures.rs
Outdated
Comment on lines
196
to
200
| if self.shutdown.try_recv() { | ||
| info!("shutdown signal received"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Do we need to wait in the main thread until this is hit?
There was a problem hiding this comment.
@scottopell mind linking that ticket here?
There was a problem hiding this comment.
https://datadoghq.atlassian.net/browse/SMPTNG-340 is the future, more proper fix. I'll add this into the code as a comment
GeorgeHahn
approved these changes
Apr 3, 2024
scottopell
force-pushed
the
sopell/captures-check-shutdown-firstthing
branch
from
57fc6c5
to
1bb7d3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses a shutdown race that can occur where
record_capturesis called incorrectly after the experiment has shut down.This can result in truncated
capture.jsonresult files.Motivation
Fixing a bug in capture writing.
Related issues
Additional Notes