Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asm): avoid terminate being called on native aspect [backport 2.9] #9347

Merged
merged 1 commit into from
May 22, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented May 22, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added the ASM Application Security Monitoring label May 22, 2024
@juanjux juanjux self-assigned this May 22, 2024
@juanjux juanjux requested review from a team as code owners May 22, 2024 10:48
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-9330-to-2.9-manual
Commit report: fa7fe3e
Test service: dd-trace-py

✅ 0 Failed, 117649 Passed, 57509 Skipped, 3h 52m 31.87s Total duration (5h 18m 52.4s time saved)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.88889% with 123 lines in your changes are missing coverage. Please review.

Project coverage is 10.25%. Comparing base (0a568f1) to head (fa7fe3e).

Files Patch % Lines
tests/appsec/iast/aspects/test_ospath_aspects.py 0.00% 71 Missing ⚠️
ddtrace/appsec/_iast/_taint_tracking/aspects.py 21.42% 44 Missing ⚠️
...ppsec/iast/aspects/test_bytearray_extend_aspect.py 0.00% 6 Missing ⚠️
ddtrace/appsec/_iast/_ast/visitor.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              2.9    #9347       +/-   ##
===========================================
- Coverage   41.26%   10.25%   -31.02%     
===========================================
  Files        1269     1252       -17     
  Lines      120461   119166     -1295     
===========================================
- Hits        49707    12215    -37492     
- Misses      70754   106951    +36197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avara1986
Copy link
Member

This PR is a backport of #9330

@avara1986 avara1986 merged commit 2cf87c6 into 2.9 May 22, 2024
174 of 182 checks passed
@avara1986 avara1986 deleted the backport-9330-to-2.9-manual branch May 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants