Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add memcheck tests for the new splitter aspects #9146

Merged
merged 4 commits into from
May 2, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented May 2, 2024

Description

  • Add memcheck fixtures for the new splitter aspects that were recently merged.
  • Add comments to make them easier to follow.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels May 2, 2024
@juanjux juanjux self-assigned this May 2, 2024
@juanjux juanjux requested a review from a team as a code owner May 2, 2024 09:00
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: juanjux/APPSEC-52927-memcheck-fixtures
Commit report: a65e739
Test service: dd-trace-py

✅ 0 Failed, 109438 Passed, 2201 Skipped, 6m 1.64s Total duration (15m 12.54s time saved)

@juanjux juanjux merged commit 7a55b3e into main May 2, 2024
80 of 81 checks passed
@juanjux juanjux deleted the juanjux/APPSEC-52927-memcheck-fixtures branch May 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants