Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: mark some flaky tests #9144

Merged
merged 3 commits into from
May 2, 2024
Merged

ci: mark some flaky tests #9144

merged 3 commits into from
May 2, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented May 1, 2024

This change marks these two ephemeral CI failures as flaky:

https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60664/workflows/e6f953d9-721e-4a27-8064-5209f7ac3a15/jobs/3805647 last touched by @zarirhamza
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60685/workflows/c25bae04-8827-4893-ac67-f239b2226774/jobs/3806940 last touched by @erikayasuda

It also adds verbose output to the appsec_iast test suite to aid in figuring out which test or tests generates this ephemeral segfault: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60686/workflows/21d8cecd-9345-4e16-9157-71425bd65ccb/jobs/3807035

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label May 1, 2024
@emmettbutler emmettbutler requested review from a team as code owners May 1, 2024 16:34
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 1, 2024

Datadog Report

Branch report: emmett.butler/mark-flakes
Commit report: 93c38d6
Test service: dd-trace-py

✅ 0 Failed, 115718 Passed, 59132 Skipped, 2h 51m 42.99s Total duration (7h 13m 39.43s time saved)

@emmettbutler emmettbutler enabled auto-merge (squash) May 2, 2024 13:23
@emmettbutler emmettbutler merged commit 5f9e15d into main May 2, 2024
144 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/mark-flakes branch May 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants