Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip non-user frames in exception replay #9015

Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Apr 17, 2024

We skip non-user frames when collecting snapshots as part of the exception replay feature.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We skip non-user frames when collecting snapshots as part of the
exception replay feature.
@P403n1x87 P403n1x87 self-assigned this Apr 17, 2024
@P403n1x87 P403n1x87 marked this pull request as ready for review April 26, 2024 10:23
@P403n1x87 P403n1x87 requested review from a team as code owners April 26, 2024 10:23
@P403n1x87 P403n1x87 enabled auto-merge (squash) April 26, 2024 10:23
@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Apr 26, 2024
@P403n1x87 P403n1x87 merged commit 7e5d79b into DataDog:main May 9, 2024
52 of 53 checks passed
@P403n1x87 P403n1x87 deleted the chore/exception-replay-skip-non-user-frames branch June 21, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants