Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix grpc contrib codeowners #8975

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Apr 15, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Apr 15, 2024
@juanjux juanjux self-assigned this Apr 15, 2024
@juanjux juanjux requested review from a team as code owners April 15, 2024 10:09
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 Thanks!

@juanjux juanjux enabled auto-merge (squash) April 15, 2024 10:17
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: juanjux/fix-codeowners-grpc
Commit report: ff45c5d
Test service: dd-trace-py

❌ 4 Failed (3 Known Flaky), 20472 Passed, 152137 Skipped, 6h 16m 33.75s Total duration (5h 19m 51.45s time saved)

❌ Failed Tests (4)

  • test_llm_logs[ddtrace_config_langchain0] - test_langchain_community.py - ❄️ Known flaky - Details

    Expand for error
     Attempted to access streaming response content, without having called \`read()\`.
    
  • test_openai_llm_error - test_langchain_community.py - ❄️ Known flaky - Details

    Expand for error
     At request <Request GET /test/session/snapshot >:
        At snapshot (token='tests.contrib.langchain.test_langchain_community.test_openai_llm_error'):
         - Directory: /snapshots
         - CI mode: 1
         - Trace File: /snapshots/tests.contrib.langchain.test_langchain_community.test_openai_llm_error.json
         - Stats File: /snapshots/tests.contrib.langchain.test_langchain_community.test_openai_llm_error_tracestats.json
         At compare of 1 expected trace(s) to 1 received trace(s):
          At trace 'langchain.request' (1 spans):
           At snapshot compare of span 'langchain.request' at position 1 in trace:
            - Expected span:
     ...
    
  • test_openai_llm_metrics - test_langchain_community.py - ❄️ Known flaky - Details

    Expand for error
     Attempted to access streaming response content, without having called \`read()\`.
    
  • test_multiple_process_partial_failure - test_tracer_flare.py - Details

    Expand for error
     The directory tracer_flare still exists
     assert not True
      +  where True = <function exists at 0x7fe2e471eb90>(PosixPath('tracer_flare'))
      +    where <function exists at 0x7fe2e471eb90> = <module 'posixpath' from '/root/.pyenv/versions/3.7.16/lib/python3.7/posixpath.py'>.exists
      +      where <module 'posixpath' from '/root/.pyenv/versions/3.7.16/lib/python3.7/posixpath.py'> = os.path
    

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2024

Benchmarks

Benchmark execution time: 2024-04-15 11:57:14

Comparing candidate commit b4ad854 in PR branch juanjux/fix-codeowners-grpc with baseline commit 0f4f240 in branch main.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 197 metrics, 9 unstable metrics.

scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

  • 🟥 max_rss_usage [+544.448KB; +618.816KB] or [+2.554%; +2.903%]

scenario:httppropagationextract-wsgi_empty_headers

  • 🟥 max_rss_usage [+442.283KB; +825.839KB] or [+2.083%; +3.890%]

scenario:httppropagationinject-with_sampling_priority

  • 🟩 max_rss_usage [-748.101KB; -690.005KB] or [-3.423%; -3.157%]

scenario:httppropagationinject-with_tags_max_size

  • 🟩 max_rss_usage [-624.968KB; -578.027KB] or [-2.858%; -2.643%]

@juanjux juanjux merged commit 02e033d into main Apr 15, 2024
51 checks passed
@juanjux juanjux deleted the juanjux/fix-codeowners-grpc branch April 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants