-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: replace apm-core-python with python-guild where it makes sense in codeowners #8965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial gut reactions
Datadog ReportBranch report: ❌ 1 Failed (1 Known Flaky), 131659 Passed, 41358 Skipped, 8h 7m 30.93s Total duration (3h 29m 3.47s time saved) ❌ Failed Tests (1)
⌛ Performance Regressions vs Default Branch (1)
|
BenchmarksBenchmark execution time: 2024-04-29 21:06:47 Comparing candidate commit a9914ad in PR branch Found 5 performance improvements and 17 performance regressions! Performance is the same for 179 metrics, 9 unstable metrics. scenario:httppropagationextract-b3_headers
scenario:httppropagationextract-medium_header_no_matches
scenario:httppropagationextract-valid_headers_all
scenario:httppropagationextract-wsgi_medium_valid_headers_all
scenario:otelspan-start-finish-telemetry
scenario:sethttpmeta-all-disabled
scenario:sethttpmeta-all-enabled
scenario:sethttpmeta-no-collectipvariant
scenario:sethttpmeta-no-useragentvariant
scenario:sethttpmeta-obfuscation-no-query
scenario:sethttpmeta-obfuscation-regular-case-explicit-query
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-explicit-query
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:sethttpmeta-useragentvariant_exists_2
scenario:sethttpmeta-useragentvariant_exists_3
scenario:sethttpmeta-useragentvariant_not_exists_1
scenario:sethttpmeta-useragentvariant_not_exists_2
scenario:span-start-finish
scenario:tracer-large
scenario:tracer-medium
scenario:tracer-small
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have @DataDog/lang-platform-python so we probably want to do: s/apm-core-python/lang-platform-python/g
, wdyt?
tests/opentelemetry @DataDog/python-guild | ||
tests/opentracer @DataDog/apm-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the opentelemetry and opentracer files should be assigned to the API team.
cc @mabdinur who might be able to help us figure out which github team to assign here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brettlangdon @mabdinur what is the "API team" referring to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmettbutler SDK APIs, the new tracing team (the "not IDM" team)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brettlangdon I can't find any team with a name like that in the Github teams list https://github.com/orgs/DataDog/teams?query=api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmettbutler yeah, they need to create the GitHub team.
@brettlangdon I don't think I have the permission level necessary to resolve the linting errors on this pull request. Could you handle that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than getting sdk apis assigned properly, this looks ok to me.
This change expands the ownership of a lot of files to the
python-guild
github team, with the goal of widening the bottleneck on pull request approvals.apm-core-python
is still the default owner for all files, so anything that's overlooked here will still have a backstop reviewer. Hopefully this change reduces the drag felt by contributors to this repository from other Datadog teams.Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist