Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace apm-core-python with python-guild where it makes sense in codeowners #8965

Closed
wants to merge 7 commits into from

Conversation

emmettbutler
Copy link
Collaborator

This change expands the ownership of a lot of files to the python-guild github team, with the goal of widening the bottleneck on pull request approvals. apm-core-python is still the default owner for all files, so anything that's overlooked here will still have a backstop reviewer. Hopefully this change reduces the drag felt by contributors to this repository from other Datadog teams.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial gut reactions

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/guild-owners
Commit report: b1ff4e7
Test service: dd-trace-py

❌ 1 Failed (1 Known Flaky), 131659 Passed, 41358 Skipped, 8h 7m 30.93s Total duration (3h 29m 3.47s time saved)
⌛ 1 Performance Regression

❌ Failed Tests (1)

  • test_lcel_chain_batch - test_langchain_community.py - ❄️ Known flaky - Details

    Expand for error
     At request <Request GET /test/session/snapshot >:
        At snapshot (token='tests.contrib.langchain.test_langchain_community.test_lcel_chain_batch'):
         - Directory: /snapshots
         - CI mode: 1
         - Trace File: /snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_batch.json
         - Stats File: /snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_batch_tracestats.json
         At compare of 1 expected trace(s) to 1 received trace(s):
          At trace 'langchain.request' (4 spans):
           At snapshot compare of span 'langchain.request' at position 1 in trace:
            - Expected span:
     ...
    

⌛ Performance Regressions vs Default Branch (1)

  • test_snowflake_ot_fetchall_multiple_rows - test_snowflake.py 4.19s (+3.68s, +719%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Apr 12, 2024

Benchmarks

Benchmark execution time: 2024-04-29 21:06:47

Comparing candidate commit a9914ad in PR branch emmett.butler/guild-owners with baseline commit 7c89580 in branch main.

Found 5 performance improvements and 17 performance regressions! Performance is the same for 179 metrics, 9 unstable metrics.

scenario:httppropagationextract-b3_headers

  • 🟩 max_rss_usage [-703.581KB; -485.079KB] or [-3.311%; -2.282%]

scenario:httppropagationextract-medium_header_no_matches

  • 🟥 max_rss_usage [+441.593KB; +711.431KB] or [+2.135%; +3.439%]

scenario:httppropagationextract-valid_headers_all

  • 🟥 max_rss_usage [+479.432KB; +734.213KB] or [+2.331%; +3.570%]

scenario:httppropagationextract-wsgi_medium_valid_headers_all

  • 🟥 max_rss_usage [+491.226KB; +697.023KB] or [+2.386%; +3.385%]

scenario:otelspan-start-finish-telemetry

  • 🟥 max_rss_usage [+716.387KB; +799.543KB] or [+3.286%; +3.667%]

scenario:sethttpmeta-all-disabled

  • 🟩 max_rss_usage [-781.606KB; -712.205KB] or [-3.610%; -3.290%]

scenario:sethttpmeta-all-enabled

  • 🟩 max_rss_usage [-758.727KB; -687.981KB] or [-3.507%; -3.180%]

scenario:sethttpmeta-no-collectipvariant

  • 🟥 max_rss_usage [+630.228KB; +786.578KB] or [+3.011%; +3.758%]

scenario:sethttpmeta-no-useragentvariant

  • 🟩 max_rss_usage [-734.839KB; -657.801KB] or [-3.399%; -3.042%]

scenario:sethttpmeta-obfuscation-no-query

  • 🟥 max_rss_usage [+666.761KB; +747.178KB] or [+3.190%; +3.575%]

scenario:sethttpmeta-obfuscation-regular-case-explicit-query

  • 🟩 max_rss_usage [-633.003KB; -555.247KB] or [-2.897%; -2.542%]

scenario:sethttpmeta-obfuscation-send-querystring-disabled

  • 🟥 max_rss_usage [+643.739KB; +805.836KB] or [+3.045%; +3.812%]

scenario:sethttpmeta-obfuscation-worst-case-explicit-query

  • 🟥 max_rss_usage [+664.481KB; +731.845KB] or [+3.145%; +3.464%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟥 max_rss_usage [+679.844KB; +761.129KB] or [+3.217%; +3.602%]

scenario:sethttpmeta-useragentvariant_exists_2

  • 🟥 max_rss_usage [+559.913KB; +713.943KB] or [+2.674%; +3.410%]

scenario:sethttpmeta-useragentvariant_exists_3

  • 🟥 max_rss_usage [+622.296KB; +700.302KB] or [+2.977%; +3.350%]

scenario:sethttpmeta-useragentvariant_not_exists_1

  • 🟥 max_rss_usage [+559.635KB; +636.397KB] or [+2.661%; +3.025%]

scenario:sethttpmeta-useragentvariant_not_exists_2

  • 🟥 max_rss_usage [+476.828KB; +615.575KB] or [+2.266%; +2.925%]

scenario:span-start-finish

  • 🟥 max_rss_usage [+720.560KB; +792.502KB] or [+3.496%; +3.845%]

scenario:tracer-large

  • 🟥 max_rss_usage [+684.978KB; +741.659KB] or [+3.148%; +3.408%]

scenario:tracer-medium

  • 🟥 max_rss_usage [+517.377KB; +595.506KB] or [+2.497%; +2.874%]

scenario:tracer-small

  • 🟥 max_rss_usage [+731.220KB; +798.636KB] or [+3.553%; +3.880%]

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have @DataDog/lang-platform-python so we probably want to do: s/apm-core-python/lang-platform-python/g, wdyt?

Comment on lines +25 to +26
tests/opentelemetry @DataDog/python-guild
tests/opentracer @DataDog/apm-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the opentelemetry and opentracer files should be assigned to the API team.

cc @mabdinur who might be able to help us figure out which github team to assign here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettlangdon @mabdinur what is the "API team" referring to here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmettbutler SDK APIs, the new tracing team (the "not IDM" team)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettlangdon I can't find any team with a name like that in the Github teams list https://github.com/orgs/DataDog/teams?query=api

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmettbutler yeah, they need to create the GitHub team.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@emmettbutler
Copy link
Collaborator Author

@brettlangdon I don't think I have the permission level necessary to resolve the linting errors on this pull request. Could you handle that?

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than getting sdk apis assigned properly, this looks ok to me.

@emmettbutler emmettbutler deleted the emmett.butler/guild-owners branch May 7, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants