Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin circleCI images #6654

Merged
merged 2 commits into from
Aug 14, 2023
Merged

chore(ci): pin circleCI images #6654

merged 2 commits into from
Aug 14, 2023

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Aug 11, 2023

This PR pins the docker images used in our CircleCI tests. This is in preparation for the 2.0 release and freezing docker images and test dependencies for the 1.x release line to ease maintenance of the 1.x branch.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 11, 2023
@Yun-Kim Yun-Kim requested a review from a team as a code owner August 11, 2023 20:50
@majorgreys majorgreys enabled auto-merge (squash) August 14, 2023 12:53
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2023

Benchmarks

Benchmark execution time: 2023-08-14 13:42:10

Comparing candidate commit c27d4b9 in PR branch yunkim/pin-docker-images with baseline commit 1b5f01a in branch 1.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 94 metrics, 0 unstable metrics.

@majorgreys majorgreys merged commit 8918337 into 1.x Aug 14, 2023
25 checks passed
@majorgreys majorgreys deleted the yunkim/pin-docker-images branch August 14, 2023 13:57
@github-actions github-actions bot added this to the v1.19.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants