-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(httplib): avoid tracing requests made by trace writers #6635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer a ci fix. It's more of a bug fix or chore. We should update the PR title and add a release note (if required).
BenchmarksBenchmark execution time: 2023-08-11 21:03:45 Comparing candidate commit 25725d7 in PR branch Found 1 performance improvements and 3 performance regressions! Performance is the same for 90 metrics, 0 unstable metrics. scenario:sethttpmeta-obfuscation-disabled
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:span-start-finish
|
This might be a good use case for the pin object on a connection instance. wdyt? |
I tried that but didn't work for me, when disabled, it would disable the tracer for the whole integration, maybe further work is required for it to work as expected? |
389178f
to
2923971
Compare
838602a
to
ea79b93
Compare
Description
Avoids tracing http requests made by trace writers to datadog internal services (i.e. prevents the ci visibility writer from sending traced requests to internal services).
Motivation
Checklist
changelog/no-changelog
.Reviewer Checklist