-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(flask): remove APM logic from Flask WSGI middleware #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on a context that still exists by the time the test assertion runs
This reverts commit b47ab26.
explicitly set expected config because config can leak between tests
…atibility with tests that rely on the root span continuing to exist
…ler/flask-core-blockedrequest
…tler/flask-core-render
Base automatically changed from
emmett.butler/flask-core-blockedrequest
to
1.x
August 10, 2023 19:54
While they were not intended as part of the public interface, the functions removed from the patch module are a breaking change. Can we replace these functions with no-ops and include a deprecation warning? |
mabdinur
previously approved these changes
Aug 11, 2023
@majorgreys I changed the diff to avoid removing any public functions. |
mabdinur
previously approved these changes
Aug 11, 2023
mabdinur
approved these changes
Aug 16, 2023
avara1986
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ASM
Application Security Monitoring
changelog/no-changelog
A changelog entry is not required for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the APM-specific logic from the Flask WSGI middleware and the Flask
*render*
wrapper functions toddtrace.trace_handlers
, clarifying the separation of concerns between Contribs (Flask) and Products (APM).Checklist
changelog/no-changelog
.Reviewer Checklist