Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flask): remove APM logic from Flask WSGI middleware #6394

Merged
merged 255 commits into from
Aug 17, 2023

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jul 18, 2023

This pull request moves the APM-specific logic from the Flask WSGI middleware and the Flask *render* wrapper functions to ddtrace.trace_handlers, clarifying the separation of concerns between Contribs (Flask) and Products (APM).

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

…on a context that still exists by the time the test assertion runs
explicitly set expected config because config can leak between tests
…atibility with tests that rely on the root span continuing to exist
Base automatically changed from emmett.butler/flask-core-blockedrequest to 1.x August 10, 2023 19:54
@emmettbutler emmettbutler marked this pull request as ready for review August 10, 2023 20:38
@majorgreys
Copy link
Contributor

While they were not intended as part of the public interface, the functions removed from the patch module are a breaking change. Can we replace these functions with no-ops and include a deprecation warning?

mabdinur
mabdinur previously approved these changes Aug 11, 2023
@emmettbutler emmettbutler enabled auto-merge (squash) August 11, 2023 15:27
@emmettbutler
Copy link
Collaborator Author

@majorgreys I changed the diff to avoid removing any public functions.

mabdinur
mabdinur previously approved these changes Aug 11, 2023
@emmettbutler emmettbutler merged commit 4553223 into 1.x Aug 17, 2023
46 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/flask-core-render branch August 17, 2023 13:06
@github-actions github-actions bot added this to the v1.19.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants