Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): reduce lock profiler log spam [backport 2.16] #11388

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 079e478 from #11377 to 2.16.

The lock profiler would log a warning if it couldn't determine a
name for a lock, and it would try determining a name multiple times for
the same lock. This lead to excessive log spam. Downgrade this to a
debug log and only try to determine the name once.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

PROF-10898

The lock profiler would log a warning if it couldn't determine a
name for a lock, and it would try determining a name multiple times for
the same lock. This lead to excessive log spam. Downgrade this to a
debug log and only try to determine the name once.

(cherry picked from commit 079e478)
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-13 20:51:30

Comparing candidate commit e22b297 in PR branch backport-11377-to-2.16 with baseline commit 29f1c3c in branch 2.16.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@quinna-h quinna-h closed this Nov 13, 2024
@quinna-h quinna-h reopened this Nov 13, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-reduce-lock-profiler-log-spam-5931d957ff1becd4.yaml  @DataDog/apm-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python

@taegyunkim taegyunkim enabled auto-merge (squash) November 13, 2024 22:00
@taegyunkim taegyunkim merged commit 50ef691 into 2.16 Nov 13, 2024
622 of 628 checks passed
@taegyunkim taegyunkim deleted the backport-11377-to-2.16 branch November 13, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants