Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove compat.stringify usage from gunicorn test #11341

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Nov 8, 2024

While reviewing gunicorn's flaky tests with @brettlangdon , we found that compat stringify doesn't exist leading to errors such as https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/692703418:

    def gunicorn_server(gunicorn_server_settings, tmp_path):
        cfg_file = tmp_path / "gunicorn.conf.py"
        cfg = build_config_file(gunicorn_server_settings)
>       cfg_file.write_text(compat.stringify(cfg))
E       AttributeError: module 'ddtrace.internal.compat' has no attribute 'stringify'. Did you mean: 'StringIO'?

The closest is maybe_stringify, added in this PR: https://github.com/DataDog/dd-trace-py/pull/2465/files

This PR removes the compat.stringify usage and removes the flaky marker.

Also related to efforts in #11274 .

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 8, 2024

CODEOWNERS have been resolved as:

tests/contrib/gunicorn/test_gunicorn.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@wantsui wantsui changed the title chore: Remove compat.stringify usage from gunicorn test chore: remove compat.stringify usage from gunicorn test Nov 8, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Benchmark execution time: 2024-11-13 15:39:21

Comparing candidate commit 2aa780f in PR branch wantsui/fix-gunicorn-flaky-test with baseline commit 48e8952 in branch main.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 386 metrics, 2 unstable metrics.

scenario:iast_aspects-ljust_aspect

  • 🟥 execution_time [+1.162µs; +1.274µs] or [+8.416%; +9.225%]

scenario:iast_aspects-ospathnormcase_aspect

  • 🟩 execution_time [-256.024ns; -220.915ns] or [-9.571%; -8.258%]

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 12, 2024
@wantsui wantsui marked this pull request as ready for review November 13, 2024 21:44
@wantsui wantsui requested review from a team as code owners November 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant