-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iast): native str aspect #10978
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Juanjo Alvarez <[email protected]>
|
result_o = py::reinterpret_borrow<py::str>(result_pyo); | ||
} | ||
|
||
TRY_CATCH_ASPECT("str_aspect", return result_o, , { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the two commas (, ,
) intended? What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is, you can check other aspects
https://github.com/DataDog/dd-trace-py/blob/main/ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectIndex.cpp#L81
BenchmarksBenchmark execution time: 2024-10-08 21:38:52 Comparing candidate commit 1aa41e0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
Description
Move the
str()
aspect to full native (requisite forrepr
andformat_value
).TODO:
Checklist
Reviewer Checklist