Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): native str aspect #10978

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Oct 8, 2024

Description

Move the str() aspect to full native (requisite for repr and format_value).

TODO:

  • More tests with propagation, the other error types and other input types.
  • Remove the Python aspect and wire this one.
  • Check for leaks.
  • Check performance.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux self-assigned this Oct 8, 2024
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectStr.cpp              @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectStr.h                @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/tests/test_str_aspect.cpp          @DataDog/asm-python

@juanjux juanjux changed the title choras(iast): native str aspect chore(iast): native str aspect Oct 8, 2024
result_o = py::reinterpret_borrow<py::str>(result_pyo);
}

TRY_CATCH_ASPECT("str_aspect", return result_o, , {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two commas (, ,) intended? What does this do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pr-commenter
Copy link

pr-commenter bot commented Oct 8, 2024

Benchmarks

Benchmark execution time: 2024-10-08 21:38:52

Comparing candidate commit 1aa41e0 in PR branch juanjux/native-str-aspect with baseline commit cd1753d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants