Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix alpine test #10964

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore(ci): fix alpine test #10964

merged 1 commit into from
Oct 7, 2024
+1 −1

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Oct 7, 2024 •
edited
Loading

Fix for alpine test failing on gitlab after some changes on system tests.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@christophe-papazian christophe-papazian changed the title fix alpine test fix(ci): fix alpine test Oct 7, 2024
@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. CI labels Oct 7, 2024
@christophe-papazian christophe-papazian changed the title fix(ci): fix alpine test chore(ci): fix alpine test Oct 7, 2024
@christophe-papazian christophe-papazian changed the title chore(ci): fix alpine test chore(ci): alpine test Oct 7, 2024
@christophe-papazian christophe-papazian changed the title chore(ci): alpine test chore(ci): fix alpine test Oct 7, 2024
@christophe-papazian christophe-papazian marked this pull request as ready for review October 7, 2024 15:52
@christophe-papazian christophe-papazian requested a review from a team as a code owner October 7, 2024 15:52
@christophe-papazian christophe-papazian enabled auto-merge (squash) October 7, 2024 15:54
@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Benchmarks

Benchmark execution time: 2024-10-07 15:54:30

Comparing candidate commit 80043ca in PR branch christophe-papazian/fix_alpine_test with baseline commit b380f21 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 373 metrics, 53 unstable metrics.

@christophe-papazian christophe-papazian merged commit 2af13d9 into main Oct 7, 2024
643 of 648 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/fix_alpine_test branch October 7, 2024 19:33
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
@christophe-papazian @github-actions
chore(ci): fix alpine test (#10964)
9c876bd 
Fix for alpine test failing on gitlab after some changes on system
tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 2af13d9)
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
@christophe-papazian @github-actions
chore(ci): fix alpine test (#10964)
85c9a3f 
Fix for alpine test failing on gitlab after some changes on system
tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 2af13d9)
This was referenced Oct 9, 2024
Open
Open
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
@christophe-papazian @github-actions
chore(ci): fix alpine test (#10964)
5ad00f5 
Fix for alpine test failing on gitlab after some changes on system
tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 2af13d9)
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdinur mabdinur mabdinur approved these changes

@erikayasuda erikayasuda erikayasuda approved these changes

Assignees
No one assigned
Labels
backport 2.12 backport 2.13 backport 2.14 changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophe-papazian @mabdinur @erikayasuda @taegyunkim