Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(profiling): update relnote for endpoint stack v2 #10962

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore(profiling): update relnote for endpoint stack v2 #10962

merged 2 commits into from
Oct 8, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Oct 7, 2024 •
edited by brettlangdon
Loading

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner October 7, 2024 14:38
@taegyunkim taegyunkim changed the title chore: update relnote for endpoint stack v2 chore(profiling): update relnote for endpoint stack v2 Oct 7, 2024
@taegyunkim taegyunkim added the Profiling Continous Profling label Oct 7, 2024
@taegyunkim taegyunkim enabled auto-merge (squash) October 7, 2024 14:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-fix-stack-v2-endpoint-82a1e26366166b8d.yaml  @DataDog/apm-python

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-08 16:23:38

Comparing candidate commit bb77376 in PR branch taegyunkim/relnote-fix with baseline commit a064a19 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 365 metrics, 53 unstable metrics.

@taegyunkim taegyunkim merged commit cd1753d into main Oct 8, 2024
627 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/relnote-fix branch October 8, 2024 16:31
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@taegyunkim @github-actions
chore(profiling): update relnote for endpoint stack v2 (#10962)
1774e01 
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit cd1753d)
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Open
2 tasks
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@taegyunkim @github-actions
chore(profiling): update relnote for endpoint stack v2 (#10962)
815e2c2 
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit cd1753d)
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Open
2 tasks
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@taegyunkim @github-actions
chore(profiling): update relnote for endpoint stack v2 (#10962)
66a9733 
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit cd1753d)
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

@mabdinur mabdinur Awaiting requested review from mabdinur mabdinur is a code owner automatically assigned from DataDog/apm-python

Assignees
No one assigned
Labels
backport 2.12 backport 2.13 backport 2.14 changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taegyunkim @emmettbutler @brettlangdon