Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): separate pytest outcome processing into its own function #10960

Merged

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Oct 7, 2024

This separates the outcome processing for pytest into a separate function to allow for easier refactoring of code for Early Flake Detection retries.

It also makes the status an optional argument for various finish() calls to allow for finishing without overriding the test status.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Oct 7, 2024
@romainkomorndatadog romainkomorndatadog self-assigned this Oct 7, 2024
@romainkomorndatadog romainkomorndatadog requested a review from a team as a code owner October 7, 2024 11:17
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CODEOWNERS have been resolved as:

ddtrace/contrib/pytest/_plugin_v2.py                                    @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/api/_test.py                             @DataDog/ci-app-libraries
ddtrace/internal/test_visibility/api.py                                 @DataDog/ci-app-libraries
static-analysis.datadog.yml                                             @DataDog/apm-core-python

@avara1986 avara1986 enabled auto-merge (squash) October 7, 2024 11:48
@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Benchmarks

Benchmark execution time: 2024-10-07 13:59:12

Comparing candidate commit cd10cf5 in PR branch romain.komorn/SDTEST-869/separate_outcome_processing with baseline commit 6ae8477 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 367 metrics, 53 unstable metrics.

…f github.com:DataDog/dd-trace-py into romain.komorn/SDTEST-869/separate_outcome_processing
@romainkomorndatadog romainkomorndatadog enabled auto-merge (squash) October 7, 2024 13:57
@romainkomorndatadog romainkomorndatadog merged commit b380f21 into main Oct 7, 2024
628 of 630 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/SDTEST-869/separate_outcome_processing branch October 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants