-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci_visibility): separate pytest outcome processing into its own function #10960
Merged
romainkomorndatadog
merged 6 commits into
main
from
romain.komorn/SDTEST-869/separate_outcome_processing
Oct 7, 2024
Merged
chore(ci_visibility): separate pytest outcome processing into its own function #10960
romainkomorndatadog
merged 6 commits into
main
from
romain.komorn/SDTEST-869/separate_outcome_processing
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romainkomorndatadog
added
changelog/no-changelog
A changelog entry is not required for this PR.
CI App
labels
Oct 7, 2024
|
vitor-de-araujo
approved these changes
Oct 7, 2024
BenchmarksBenchmark execution time: 2024-10-07 13:59:12 Comparing candidate commit cd10cf5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 367 metrics, 53 unstable metrics. |
emmettbutler
approved these changes
Oct 7, 2024
…f github.com:DataDog/dd-trace-py into romain.komorn/SDTEST-869/separate_outcome_processing
romainkomorndatadog
deleted the
romain.komorn/SDTEST-869/separate_outcome_processing
branch
October 7, 2024 14:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the outcome processing for
pytest
into a separate function to allow for easier refactoring of code for Early Flake Detection retries.It also makes the status an optional argument for various
finish()
calls to allow for finishing without overriding the test status.Checklist
Reviewer Checklist