Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): improve iast scripts #10902

Merged
merged 17 commits into from
Oct 8, 2024
Merged

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Oct 2, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added the ASM Application Security Monitoring label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CODEOWNERS have been resolved as:

.gitlab/tests/appsec.yml                                                @DataDog/asm-python
ddtrace/appsec/_iast/__init__.py                                        @DataDog/asm-python
ddtrace/internal/module.py                                              @DataDog/debugger-python @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
scripts/iast/README                                                     @DataDog/asm-python
scripts/iast/mod_leak_functions.py                                      @DataDog/asm-python
scripts/iast/requirements.txt                                           @DataDog/asm-python
scripts/iast/run_memory.sh                                              @DataDog/asm-python
scripts/iast/run_memray.sh                                              @DataDog/asm-python
scripts/iast/run_references.sh                                          @DataDog/asm-python
scripts/iast/test_references.py                                         @DataDog/asm-python
tests/appsec/iast_aggregated_memcheck/test_aggregated_memleaks.py       @DataDog/asm-python
scripts/iast/leak_functions.py                                          @DataDog/asm-python

scripts/iast/leak_functions.py Outdated Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Outdated Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 2, 2024

Datadog Report

Branch report: avara1986/iast_script_improvements
Commit report: 07d9260
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 29m 45.55s Total duration (6m 13.27s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024

Benchmarks

Benchmark execution time: 2024-10-07 12:28:28

Comparing candidate commit 07d9260 in PR branch avara1986/iast_script_improvements with baseline commit 6ae8477 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 373 metrics, 53 unstable metrics.

@avara1986 avara1986 marked this pull request as ready for review October 3, 2024 07:05
@avara1986 avara1986 requested review from a team as code owners October 3, 2024 07:05
@avara1986 avara1986 added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 4, 2024
avara1986 added a commit that referenced this pull request Oct 8, 2024
A memory leak was introduced in #10540 when "py" was removed from the
deny list. This caused a leak in FastAPI with the `pypika` package.
#10846 patched the issue, and #10947 resolved it. Now, we're re-enabling
those packages.

This PR is tested in #10902

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@avara1986 avara1986 merged commit a064a19 into main Oct 8, 2024
651 of 652 checks passed
@avara1986 avara1986 deleted the avara1986/iast_script_improvements branch October 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants