Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update codeowners for gitlab suites #10547

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Sep 6, 2024

This change updates codeowners for suites defined in gitlab. It also moves llmobs tests to their own file for this purpose.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

move llmobs tests to their own file
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CODEOWNERS have been resolved as:

.gitlab/tests/llmobs.yml                                                @DataDog/ml-observability
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests/contrib.yml                                               @DataDog/python-guild @DataDog/apm-core-python

@emmettbutler emmettbutler enabled auto-merge (squash) September 6, 2024 19:36
@pr-commenter
Copy link

pr-commenter bot commented Sep 6, 2024

Benchmarks

Benchmark execution time: 2024-09-06 19:59:42

Comparing candidate commit 18343b0 in PR branch emmett.butler/gitlab-owners with baseline commit 2730c1c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 202 metrics, 2 unstable metrics.

@emmettbutler emmettbutler added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Sep 7, 2024
@emmettbutler emmettbutler merged commit 70fb288 into main Sep 7, 2024
431 of 432 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/gitlab-owners branch September 7, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants