Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move many suites with no service dependencies to gitlab from circleci #10537

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Sep 5, 2024

This change moves a bunch of test suites from circleci to gitlab for billing purposes.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners September 5, 2024 19:15
@emmettbutler emmettbutler marked this pull request as draft September 5, 2024 19:16
Copy link
Contributor

github-actions bot commented Sep 5, 2024

CODEOWNERS have been resolved as:

.gitlab/tests/debugging.yml                                             @DataDog/python-guild @DataDog/apm-core-python
.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests/contrib.yml                                               @DataDog/python-guild @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 5, 2024

Datadog Report

Branch report: emmett.butler/gitlab-snapshots-2
Commit report: 1cf39dc
Test service: dd-trace-py

✅ 0 Failed, 10706 Passed, 998 Skipped, 1h 59m 4.03s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • test_request_ipblock_nomatch_200 - test_django_appsec_snapshots.py - Last Failure

    Expand for error
     Unexpected test failure during snapshot test: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fe9302dbf70>: Failed to establish a new connection: [Errno 111] Connection refused'))
    

@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Benchmarks

Benchmark execution time: 2024-09-06 18:43:36

Comparing candidate commit 1cf39dc in PR branch emmett.butler/gitlab-snapshots-2 with baseline commit dafd6db in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 354 metrics, 46 unstable metrics.

@emmettbutler emmettbutler marked this pull request as ready for review September 6, 2024 13:48
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 6, 2024
@emmettbutler emmettbutler enabled auto-merge (squash) September 6, 2024 18:22
.gitlab/tests/contrib.yml Show resolved Hide resolved
.gitlab/tests/contrib.yml Show resolved Hide resolved
@emmettbutler emmettbutler merged commit 2730c1c into main Sep 6, 2024
467 of 468 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/gitlab-snapshots-2 branch September 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants