Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: moved unittest config to Gitlab #10513

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Conversation

jessicagamio
Copy link
Contributor

@jessicagamio jessicagamio commented Sep 4, 2024

  • Removed unittest from config.templ.yaml file in circleCI
  • Added unittest to the contrib.yml file in Gitlab

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 4, 2024

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests/contrib.yml                                               @DataDog/python-guild @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
tests/contrib/unittest/test_unittest_snapshot.py                        @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_generates_coverage_correctly.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_generates_coverage_correctly_with_skipped.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_generates_source_file_data.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_force_run_multiple_unskippable_tests.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_force_run_unskippable_tests.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_include_custom_tests.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_include_lines_pct.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_report_coverage_by_test_with_itr_skipped.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_report_coverage_by_test_with_itr_skipped_multiple.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_skip_invalid_unskippable_tests.json  @DataDog/apm-python
tests/snapshots/tests.contrib.unittest.test_unittest_snapshot.test_unittest_will_skip_unskippable_test_if_skip_decorator.json  @DataDog/apm-python

@jessicagamio jessicagamio added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 4, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 4, 2024

Datadog Report

Branch report: jessicagamio_migrate_gitlab
Commit report: 37d3268
Test service: dd-trace-py

✅ 0 Failed, 7125 Passed, 17935 Skipped, 1h 46m 22.6s Total duration (7.05s time saved)

@erikayasuda
Copy link
Contributor

Looks like the unittest tests are failing because of a service name mismatch? Otherwise LGTM

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-05 22:23:49

Comparing candidate commit 37d3268 in PR branch jessicagamio_migrate_gitlab with baseline commit 3d4d710 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim removed their request for review September 5, 2024 13:10
@mabdinur
Copy link
Contributor

mabdinur commented Sep 5, 2024

@jessicagamio The unittest integration does not generate the same traces/spans in different environments. Span's will have different tags depending on whether they are run in circleci, locally, or in gitlab. This is expected. Migrating these tests from circleci to gitlab will require updating snapshot tests.

cc: @romainkomorndatadog

@jessicagamio jessicagamio requested a review from a team as a code owner September 5, 2024 19:10
@jessicagamio jessicagamio merged commit f2b8d8d into main Sep 6, 2024
390 checks passed
@jessicagamio jessicagamio deleted the jessicagamio_migrate_gitlab branch September 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants