-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: moved unittest config to Gitlab #10513
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 7125 Passed, 17935 Skipped, 1h 46m 22.6s Total duration (7.05s time saved) |
Looks like the unittest tests are failing because of a service name mismatch? Otherwise LGTM |
BenchmarksBenchmark execution time: 2024-09-05 22:23:49 Comparing candidate commit 37d3268 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
@jessicagamio The unittest integration does not generate the same traces/spans in different environments. Span's will have different tags depending on whether they are run in circleci, locally, or in gitlab. This is expected. Migrating these tests from circleci to gitlab will require updating snapshot tests. |
Checklist
Reviewer Checklist