Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add merge_group as a trigger for status checks #10510

Closed
wants to merge 8 commits into from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Sep 4, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda requested review from a team as code owners September 4, 2024 18:35
@erikayasuda erikayasuda requested review from gnufede and emmettbutler and removed request for a team, gnufede and emmettbutler September 4, 2024 18:35
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

CODEOWNERS have been resolved as:

.github/workflows/build_deploy.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/codeql-analysis.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/django-overhead-profile.yml                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/encoders-profile.yml                                  @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/flask-overhead-profile.yml                            @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/pypa_musllinux_1_2_i686.yml                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/requirements-locks.yml                                @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/rust-ci.yml                                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/testrunner.yml                                        @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/unit_tests.yml                                        @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-06 21:36:31

Comparing candidate commit e3446f1 in PR branch add-mq-trigger with baseline commit 27335e3 in branch test-mq-main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 342 metrics, 45 unstable metrics.

scenario:iast_aspects-aspect_iast_do_add_re_compile

  • 🟥 max_rss_usage [+2.190MB; +2.599MB] or [+7.971%; +9.460%]

@erikayasuda erikayasuda added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 4, 2024
@erikayasuda erikayasuda removed this pull request from the merge queue due to a manual request Sep 4, 2024
@erikayasuda erikayasuda closed this Sep 4, 2024
@erikayasuda erikayasuda reopened this Sep 4, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 4, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 5, 2024
@erikayasuda erikayasuda removed this pull request from the merge queue due to a manual request Sep 5, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 5, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 5, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 6, 2024
@erikayasuda erikayasuda removed this pull request from the merge queue due to a manual request Sep 6, 2024
@erikayasuda erikayasuda added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2024
@erikayasuda erikayasuda reopened this Sep 11, 2024
@erikayasuda erikayasuda deleted the branch test-mq-main September 11, 2024 21:18
@erikayasuda erikayasuda deleted the add-mq-trigger branch September 11, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant