Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable starlette test #10475

Closed

Conversation

avara1986
Copy link
Member

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

CODEOWNERS have been resolved as:

.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_asm_request_context.py                                  @DataDog/asm-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python
ddtrace/contrib/internal/starlette/patch.py                             @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 2, 2024

Benchmarks

Benchmark execution time: 2024-09-02 11:49:50

Comparing candidate commit 043269c in PR branch avara1986/APPSEC-53221-starlette_frameworktest with baseline commit 225dbde in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 2, 2024

Datadog Report

Branch report: avara1986/APPSEC-53221-starlette_frameworktest
Commit report: 043269c
Test service: dd-trace-py

❌ 92 Failed (0 Known Flaky), 119253 Passed, 15437 Skipped, 2h 5m 7.5s Total Time

❌ Failed Tests (92)

This report shows up to 5 failed tests.

  • test_set_user_blocked - test_appsec_trace_utils.py - Details

    Expand for error
     assert None
      +  where None = <function get_item at 0x7f9086fa3920>('http.request.blocked', span=<Span(id=8207379041755316309,trace_id=136690463393276909703565445063407281655,parent_id=None,name=fake_span)>)
      +    where <function get_item at 0x7f9086fa3920> = core.get_item
    
  • test_request_block_request_callable - test_django_appsec.py - Details

    Expand for error
     assert None == 'application/json'
      +  where None = get_tag(('http.response.headers' + '.content-type'))
      +    where get_tag = <Span(id=9054664709199947746,trace_id=136690470840724186046931071841626653178,parent_id=None,name=django.request)>.get_tag
      +    and   'http.response.headers' = SPAN_DATA_NAMES.RESPONSE_HEADERS_NO_COOKIES
    
  • test_request_block_request_callable - test_django_appsec.py - Details

    Expand for error
     assert None == 'application/json'
      +  where None = get_tag(('http.response.headers' + '.content-type'))
      +    where get_tag = <Span(id=3150091459916963497,trace_id=136690468384651148113977197858304331915,parent_id=None,name=django.request)>.get_tag
      +    and   'http.response.headers' = SPAN_DATA_NAMES.RESPONSE_HEADERS_NO_COOKIES
    
  • test_request_block_request_callable - test_django_appsec.py - Details

    Expand for error
     assert None == 'application/json'
      +  where None = get_tag(('http.response.headers' + '.content-type'))
      +    where get_tag = <Span(id=10078268489564282233,trace_id=136690470444583373488542780897341825754,parent_id=None,name=django.request)>.get_tag
      +    and   'http.response.headers' = SPAN_DATA_NAMES.RESPONSE_HEADERS_NO_COOKIES
    
  • test_request_block_request_callable - test_django_appsec.py - Details

    Expand for error
     assert None == 'application/json'
      +  where None = get_tag(('http.response.headers' + '.content-type'))
      +    where get_tag = <Span(id=12368143718470179368,trace_id=136690470444583373482284828457225958428,parent_id=None,name=django.request)>.get_tag
      +    and   'http.response.headers' = SPAN_DATA_NAMES.RESPONSE_HEADERS_NO_COOKIES
    

@avara1986 avara1986 changed the title enable startlet test enable starlette test Sep 2, 2024
@avara1986 avara1986 closed this Sep 3, 2024
@avara1986 avara1986 deleted the avara1986/APPSEC-53221-starlette_frameworktest branch September 3, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant