Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce trace ID format utility #10444

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Aug 29, 2024

We encapsulate the trace ID formatting logic for the backend in a helper function and use it where appropriate.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We encapsulate the trace ID formatting logic for the backend in a helper
function and use it where appropriate.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 29, 2024
@P403n1x87 P403n1x87 self-assigned this Aug 29, 2024
@P403n1x87 P403n1x87 requested review from a team as code owners August 29, 2024 09:16
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 29, 2024

Datadog Report

Branch report: refactor/format-trace-id-util
Commit report: bb3fbda
Test service: dd-trace-py

✅ 0 Failed, 138066 Passed, 3306 Skipped, 6h 37m 50.69s Total duration (19.61s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2024

Benchmarks

Benchmark execution time: 2024-08-30 11:42:53

Comparing candidate commit bb3fbda in PR branch refactor/format-trace-id-util with baseline commit 4f1a3da in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@P403n1x87 P403n1x87 enabled auto-merge (squash) August 29, 2024 09:55
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/_trace/tracer.py                                                @DataDog/apm-sdk-api-python
ddtrace/debugging/_encoding.py                                          @DataDog/debugger-python
ddtrace/internal/utils/formats.py                                       @DataDog/apm-core-python
tests/debugging/test_debugger.py                                        @DataDog/debugger-python

@zacharycmontoya zacharycmontoya removed their request for review August 30, 2024 13:51
Copy link

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny comment

@P403n1x87 P403n1x87 merged commit 4e14201 into main Aug 30, 2024
274 of 275 checks passed
@P403n1x87 P403n1x87 deleted the refactor/format-trace-id-util branch August 30, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants