-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce trace ID format utility #10444
Conversation
We encapsulate the trace ID formatting logic for the backend in a helper function and use it where appropriate.
Datadog ReportBranch report: ✅ 0 Failed, 138066 Passed, 3306 Skipped, 6h 37m 50.69s Total duration (19.61s time saved) |
BenchmarksBenchmark execution time: 2024-08-30 11:42:53 Comparing candidate commit bb3fbda in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a tiny comment
We encapsulate the trace ID formatting logic for the backend in a helper function and use it where appropriate.
Checklist
Reviewer Checklist