Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(di): simplify context capturing API #10443

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Aug 29, 2024

We clean up the internal context capturing API after the recent changes that have introduced support for local variables in function probes and the exposure of globals to expression/condition evaluations.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We clean-up the internal context capturing API after the recent changes
that have introduced support for local variables in function probes and
the exposure of globals to expression/condition evaluations.
@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Aug 29, 2024
@P403n1x87 P403n1x87 self-assigned this Aug 29, 2024
@P403n1x87 P403n1x87 requested a review from a team as a code owner August 29, 2024 09:16
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 29, 2024

Datadog Report

Branch report: refactor/di-simplify-capture-context-api
Commit report: 5442b55
Test service: dd-trace-py

✅ 0 Failed, 1114 Passed, 368 Skipped, 1m 23.73s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2024

Benchmarks

Benchmark execution time: 2024-08-30 11:42:54

Comparing candidate commit 5442b55 in PR branch refactor/di-simplify-capture-context-api with baseline commit 4f1a3da in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

ddtrace/debugging/_signal/model.py Show resolved Hide resolved
ddtrace/debugging/_signal/snapshot.py Outdated Show resolved Hide resolved
ddtrace/debugging/_signal/snapshot.py Outdated Show resolved Hide resolved
ddtrace/debugging/_signal/snapshot.py Show resolved Hide resolved
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/debugging/_debugger.py                                          @DataDog/debugger-python
ddtrace/debugging/_probe/model.py                                       @DataDog/debugger-python
ddtrace/debugging/_signal/metric_sample.py                              @DataDog/debugger-python
ddtrace/debugging/_signal/model.py                                      @DataDog/debugger-python
ddtrace/debugging/_signal/snapshot.py                                   @DataDog/debugger-python
ddtrace/debugging/_signal/tracing.py                                    @DataDog/debugger-python
tests/debugging/signal/test_collector.py                                @DataDog/debugger-python
tests/debugging/signal/test_model.py                                    @DataDog/debugger-python
tests/debugging/test_debugger.py                                        @DataDog/debugger-python
tests/debugging/test_encoding.py                                        @DataDog/debugger-python

@P403n1x87 P403n1x87 enabled auto-merge (squash) August 30, 2024 09:44
@P403n1x87 P403n1x87 merged commit 5b394f1 into main Aug 30, 2024
187 of 188 checks passed
@P403n1x87 P403n1x87 deleted the refactor/di-simplify-capture-context-api branch August 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants