Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix flaky tracer tests #10436

Merged
merged 1 commit into from
Aug 29, 2024
Merged

ci: fix flaky tracer tests #10436

merged 1 commit into from
Aug 29, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Aug 28, 2024

Previous PR fixed flakiness in one part of this test, but there is a remaining bit which is also flaky.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 28, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner August 28, 2024 20:23
@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Benchmarks

Benchmark execution time: 2024-08-28 21:02:08

Comparing candidate commit 437ca1d in PR branch brettlangdon/flaky.tracer with baseline commit a909be0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@brettlangdon brettlangdon enabled auto-merge (squash) August 28, 2024 21:41
@brettlangdon brettlangdon merged commit a941420 into main Aug 29, 2024
163 of 165 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/flaky.tracer branch August 29, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants