Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(er): capture manual exceptions #10430

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Aug 28, 2024

We add a span.exception event listener when Exception Replay is enabled to capture any exception information that is manually attached to a span.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Aug 28, 2024
@P403n1x87 P403n1x87 requested review from a team as code owners August 28, 2024 15:03
@P403n1x87 P403n1x87 mentioned this pull request Aug 28, 2024
16 tasks
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 28, 2024

Datadog Report

Branch report: chore/er-capture-exception-api
Commit report: 2ce194d
Test service: dd-trace-py

✅ 0 Failed, 121904 Passed, 20088 Skipped, 3h 54m 8.12s Total duration (1m 42.43s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Benchmarks

Benchmark execution time: 2024-08-30 17:06:57

Comparing candidate commit 2ce194d in PR branch chore/er-capture-exception-api with baseline commit 12655ee in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@P403n1x87 P403n1x87 enabled auto-merge (squash) August 29, 2024 09:18
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/chore-er-capture-exception-api-86a0a00e0b412567.yaml  @DataDog/apm-python
ddtrace/bootstrap/preload.py                                            @DataDog/apm-core-python
ddtrace/debugging/_debugger.py                                          @DataDog/debugger-python
ddtrace/debugging/_exception/replay.py                                  @DataDog/debugger-python
tests/debugging/exception/test_replay.py                                @DataDog/debugger-python
tests/debugging/mocking.py                                              @DataDog/debugger-python

@P403n1x87 P403n1x87 merged commit 0a49f52 into main Aug 30, 2024
252 of 253 checks passed
@P403n1x87 P403n1x87 deleted the chore/er-capture-exception-api branch August 30, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants