Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): revert improve generate OCI package size #10409

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Aug 27, 2024

Revert #10067 which introduces a symlink deduping script to try and cut down on the OCI package size.

There is an edge case where this causes resource consumption to sky rocket for our new k8s injection tests.

It is better to revert this for now to ensure our tests are stable, and then we can revisit the optimizations.

After this revert the image size will still be ok, but should not be forgotten.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2024
@brettlangdon brettlangdon requested review from a team as code owners August 27, 2024 16:36
@brettlangdon brettlangdon enabled auto-merge (squash) August 27, 2024 16:36
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/prepare-oci-package.sh                                          @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2024

Benchmarks

Benchmark execution time: 2024-08-27 17:27:06

Comparing candidate commit f5c2d35 in PR branch revert-10067-brettlangdon/minimize.docker.image with baseline commit 297a648 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 345 metrics, 47 unstable metrics.

lib-injection/dedupe.py Show resolved Hide resolved
@erikayasuda
Copy link
Contributor

@brettlangdon Should we add a JIRA task for this in the backlog so we don't forget? 👀

@brettlangdon
Copy link
Member Author

@brettlangdon Should we add a JIRA task for this in the backlog so we don't forget? 👀

there is one already

@brettlangdon brettlangdon merged commit e1a9037 into main Aug 29, 2024
160 of 161 checks passed
@brettlangdon brettlangdon deleted the revert-10067-brettlangdon/minimize.docker.image branch August 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants