Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert - add a final dd-gitlab/finished job (#10307) #10353

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Aug 23, 2024

This reverts commit e94ed60.

This is now included in the shared pipeline template, we do not need to define it in our repo.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 23, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner August 23, 2024 14:26
@brettlangdon brettlangdon changed the title Revert "ci: add a final dd-gitlab/finished job (#10307)" ci: revert - add a final dd-gitlab/finished job (#10307) Aug 23, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Benchmarks

Benchmark execution time: 2024-08-23 15:12:52

Comparing candidate commit 3fec930 in PR branch revert-10307 with baseline commit d875d7a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

@brettlangdon brettlangdon enabled auto-merge (squash) August 23, 2024 15:32
@brettlangdon brettlangdon merged commit 6318d75 into main Aug 26, 2024
152 of 154 checks passed
@brettlangdon brettlangdon deleted the revert-10307 branch August 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants