Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Package Versions Update: redis #10333

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Updates the redis version

@github-actions github-actions bot requested a review from a team as a code owner August 22, 2024 15:38
@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2024

Benchmarks

Benchmark execution time: 2024-08-22 16:16:45

Comparing candidate commit d64a9a0 in PR branch upgrade-redis-version with baseline commit 9a114a2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

quinna-h added a commit that referenced this pull request Aug 23, 2024
- Calls `scripts/freshvenvs` to generate a list of "outdated" packages
(packages where we don't test the full range from MIN_SUPPORTED_VERSION
to MAX_SUPPORTED_VERSION)
- Automate regenerating riot requirements.txt files for each out-of-date
packages
- Gets called in GH workflow weekly cron job
         - Can adjust frequency / time - currently Sunday midnight
- TODO: open a new PR for every venv with outdated versions - right now
it stops at one.

Testing:

Github Actions workflows:
https://github.com/DataDog/dd-trace-py/actions/workflows/generate-package-versions.yml
Example PR: #10333

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Emmett Butler <[email protected]>
@quinna-h quinna-h closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant