Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asm): switch back to default if remote config stop sending the security rule file [backport 2.9] #10053

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 2, 2024

Backport e3f9004 from #10052 to 2.9.

backporting #10030

APPSEC-54105

(cherry picked from commit bc50e9c)

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

…curity rule file [backport 2.10] (#10052)

backporting #10030

APPSEC-54105

(cherry picked from commit bc50e9c)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit e3f9004)
@github-actions github-actions bot requested a review from a team as a code owner August 2, 2024 09:54
@github-actions github-actions bot added the bug label Aug 2, 2024
@github-actions github-actions bot requested a review from a team as a code owner August 2, 2024 09:54
@github-actions github-actions bot added the ASM Application Security Monitoring label Aug 2, 2024
@romainkomorndatadog romainkomorndatadog enabled auto-merge (squash) August 2, 2024 10:01
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 2, 2024

Datadog Report

Branch report: backport-10052-to-2.9
Commit report: be1102e
Test service: dd-trace-py

✅ 0 Failed, 110233 Passed, 3167 Skipped, 12m 37.44s Total duration (35m 45.67s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 2, 2024

Benchmarks

Benchmark execution time: 2024-08-02 10:58:46

Comparing candidate commit be1102e in PR branch backport-10052-to-2.9 with baseline commit 4d73860 in branch 2.9.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@christophe-papazian christophe-papazian changed the title fix(asm): switch back to default if remote config stop sending the security rule file [backport 2.10] [backport 2.9] fix(asm): switch back to default if remote config stop sending the security rule file [backport 2.9] Aug 2, 2024
auto-merge was automatically disabled August 2, 2024 11:19

Pull request was closed

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes missing coverage. Please review.

Project coverage is 10.22%. Comparing base (fc6ee13) to head (be1102e).
Report is 2 commits behind head on 2.9.

Files Patch % Lines
tests/appsec/appsec/test_remoteconfiguration.py 0.00% 10 Missing ⚠️
ddtrace/appsec/_remoteconfiguration.py 0.00% 9 Missing ⚠️
ddtrace/appsec/_processor.py 50.00% 4 Missing ⚠️
tests/appsec/appsec/test_processor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.9   #10053      +/-   ##
==========================================
- Coverage   19.06%   10.22%   -8.84%     
==========================================
  Files        1259     1258       -1     
  Lines      120828   120861      +33     
==========================================
- Hits        23032    12356   -10676     
- Misses      97796   108505   +10709     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christophe-papazian christophe-papazian merged commit 43820c8 into 2.9 Aug 2, 2024
81 of 86 checks passed
@christophe-papazian christophe-papazian deleted the backport-10052-to-2.9 branch August 2, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants