-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(asm): switch back to default if remote config stop sending the security rule file [backport 2.9] #10053
Conversation
…curity rule file [backport 2.10] (#10052) backporting #10030 APPSEC-54105 (cherry picked from commit bc50e9c) ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit e3f9004)
Datadog ReportBranch report: ✅ 0 Failed, 110233 Passed, 3167 Skipped, 12m 37.44s Total duration (35m 45.67s time saved) |
Pull request was closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.9 #10053 +/- ##
==========================================
- Coverage 19.06% 10.22% -8.84%
==========================================
Files 1259 1258 -1
Lines 120828 120861 +33
==========================================
- Hits 23032 12356 -10676
- Misses 97796 108505 +10709 ☔ View full report in Codecov by Sentry. |
Backport e3f9004 from #10052 to 2.9.
backporting #10030
APPSEC-54105
(cherry picked from commit bc50e9c)
Checklist
Reviewer Checklist