From 600a8e18698226ff6a40453a0894caf294cf21fc Mon Sep 17 00:00:00 2001 From: yahya-mouman Date: Tue, 27 Aug 2024 19:23:21 +0200 Subject: [PATCH] Remove try catches and replace them with default values --- ddtrace/llmobs/_integrations/langchain.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ddtrace/llmobs/_integrations/langchain.py b/ddtrace/llmobs/_integrations/langchain.py index f88a0f4a2c8..6671eb4e52a 100644 --- a/ddtrace/llmobs/_integrations/langchain.py +++ b/ddtrace/llmobs/_integrations/langchain.py @@ -292,12 +292,10 @@ def _llmobs_set_meta_tags_from_similarity_search( else: documents = [] for d in output_documents: - doc = Document(text=d.page_content, id=d.id or "") - try: - doc["name"] = d.metadata["name"] - except KeyError: - log.warning("Failed to extract document name metadata from similarity search output") - doc["name"] = doc["id"] + doc = Document(text=d.page_content) + doc["id"] = getattr(d, "id", "") + metadata = getattr(d, "metadata", {}) + doc["name"] = metadata.get("name", doc["id"]) documents.append(doc) try: span.set_tag_str(OUTPUT_DOCUMENTS, json.dumps(self.format_io(documents)))