From 355232146166a9742a145967ca16d1010edee869 Mon Sep 17 00:00:00 2001 From: Alberto Vara Date: Mon, 2 Sep 2024 10:30:32 +0200 Subject: [PATCH] enable startlet test --- ddtrace/contrib/internal/starlette/patch.py | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/ddtrace/contrib/internal/starlette/patch.py b/ddtrace/contrib/internal/starlette/patch.py index 2ccd19cf5d3..a0869f87f77 100644 --- a/ddtrace/contrib/internal/starlette/patch.py +++ b/ddtrace/contrib/internal/starlette/patch.py @@ -6,7 +6,6 @@ from typing import Optional # noqa:F401 import starlette -from starlette import requests as starlette_requests from starlette.concurrency import run_in_threadpool from starlette.middleware import Middleware from wrapt import ObjectProxy @@ -150,10 +149,9 @@ def traced_handler(wrapped, instance, args, kwargs): request_spans, resource_paths, ) - request_cookies = "" for name, value in scope.get("headers", []): if name == b"cookie": - request_cookies = value.decode("utf-8", errors="ignore") + _ = value.decode("utf-8", errors="ignore") break if request_spans: @@ -162,13 +160,13 @@ def traced_handler(wrapped, instance, args, kwargs): _iast_instrument_starlette_scope(scope) - trace_utils.set_http_meta( - request_spans[0], - "starlette", - request_path_params=scope.get("path_params"), - request_cookies=starlette_requests.cookie_parser(request_cookies), - route=request_spans[0].get_tag(http.ROUTE), - ) + # trace_utils.set_http_meta( + # request_spans[0], + # "starlette", + # request_path_params=scope.get("path_params"), + # request_cookies=starlette_requests.cookie_parser(request_cookies), + # route=request_spans[0].get_tag(http.ROUTE), + # ) core.dispatch("asgi.start_request", ("starlette",)) if core.get_item(HTTP_REQUEST_BLOCKED): raise trace_utils.InterruptException("starlette")