Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling) add timeline active check for fatals #2945

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 13, 2024

Description

add the missing timeline active runtime check for #2820

PROF-10117
PROF-10118
PROF-10119

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner November 13, 2024 11:41
@realFlowControl realFlowControl added this to the 1.5.0 milestone Nov 13, 2024
@github-actions github-actions bot removed this from the 1.5.0 milestone Nov 13, 2024
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (49b3dc0) to head (3914e1c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2945   +/-   ##
=========================================
  Coverage     73.62%   73.62%           
  Complexity     2529     2529           
=========================================
  Files           109      109           
  Lines         10410    10410           
=========================================
  Hits           7664     7664           
  Misses         2746     2746           
Flag Coverage Δ
tracer-php 73.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b3dc0...3914e1c. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2024-11-13 11:51:28

Comparing candidate commit 3914e1c in PR branch florian/add-timeline-active-check with baseline commit 49b3dc0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@realFlowControl realFlowControl added this to the 1.5.0 milestone Nov 13, 2024
@realFlowControl realFlowControl merged commit 66df35c into master Nov 14, 2024
700 of 726 checks passed
@realFlowControl realFlowControl deleted the florian/add-timeline-active-check branch November 14, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants