RUM-7024: Make ImageViewMapper public #2375
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-7024/expose-imageviewmapper
branch
from
b7d6837
to
3a9ae25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2375 +/- ##
===========================================
+ Coverage 70.30% 70.34% +0.04%
===========================================
Files 744 744
Lines 27721 27719 -2
Branches 4630 4630
===========================================
+ Hits 19488 19497 +9
+ Misses 6947 6931 -16
- Partials 1286 1291 +5
|
jonathanmos
force-pushed
the
jmoskovich/rum-7024/expose-imageviewmapper
branch
from
3a9ae25
to
cba5f65
Compare
jonathanmos
changed the title
| @@ -47,12 +48,12 @@ internal class ImageViewMapper( | |||
|
|
|||
| val drawable = view.drawable?.current ?: return wireframes | |||
|
|
|||
| val parentRect = imageViewUtils.resolveParentRectAbsPosition(view) | |||
| val contentRect = imageViewUtils.resolveContentRectWithScaling(view, drawable) | |||
| val parentRect = ImageViewUtils.resolveParentRectAbsPosition(view) | |||
There was a problem hiding this comment.
what's the purpose of changing this line?
There was a problem hiding this comment.
Warning
This here is a regression going in the wrong way: replacing a call to an interface dependency with a call to a singleton object is not something we want to do.
We can create a public constructor with a default that will automatically inject the ImageViewUtils if none is provided but we shouldn't rely directly on the object
| @@ -47,12 +48,12 @@ internal class ImageViewMapper( | |||
|
|
|||
| val drawable = view.drawable?.current ?: return wireframes | |||
|
|
|||
| val parentRect = imageViewUtils.resolveParentRectAbsPosition(view) | |||
| val contentRect = imageViewUtils.resolveContentRectWithScaling(view, drawable) | |||
| val parentRect = ImageViewUtils.resolveParentRectAbsPosition(view) | |||
There was a problem hiding this comment.
Warning
This here is a regression going in the wrong way: replacing a call to an interface dependency with a call to a singleton object is not something we want to do.
We can create a public constructor with a default that will automatically inject the ImageViewUtils if none is provided but we shouldn't rely directly on the object
What does this PR do?
Exposes
ImageViewMapperso that it can be used by cross-platform frameworks.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)