Lazy RUM raw event creation in event generator methods #2363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does a bit of the optimization for the methods in
RumEventExt
: when random RUM raw event needs to be created, we are avoiding creating all of them and then selecting only one, but instead selecting the type and then creating only the selected one.This gives a benefit for the tests where a lot of events are created. For example, for the
RumViewScopeTest#M produce event safe for serialization W handleEvent()
where there is a 1000 iterations loop to callRumMonitor#handleEvent
this change is reducing execution time from 15s to 2s (and it will be much less redundant objects created, less work for GC).Review checklist (to be filled by reviewers)