Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug signing configs for local release build & missing proguard rules #2344

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

  • Use debug signing configs for local release build of sample app
  • Add missing proguard rules for sample app

Motivation

For the convenience of local release build test

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners October 24, 2024 14:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (caa2a5d) to head (9e47213).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2344      +/-   ##
===========================================
- Coverage    70.53%   70.37%   -0.16%     
===========================================
  Files          740      740              
  Lines        27630    27630              
  Branches      4627     4627              
===========================================
- Hits         19487    19442      -45     
- Misses        6878     6896      +18     
- Partials      1265     1292      +27     

see 23 files with indirect coverage changes

@ambushwork ambushwork merged commit fcfbbab into develop Oct 25, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/fix-sample-app branch October 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants