Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkable mapper privacy issue #2343

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

Before, checkable mapper was using image privacy to mask the components, Checkbox, CheckedTextView, Switch are affected.
We actually need to use Text & input privacy to mask them.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.35%. Comparing base (caa2a5d) to head (1224430).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ternal/recorder/mapper/CheckableWireframeMapper.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2343      +/-   ##
===========================================
- Coverage    70.53%   70.35%   -0.18%     
===========================================
  Files          740      740              
  Lines        27630    27633       +3     
  Branches      4627     4628       +1     
===========================================
- Hits         19487    19439      -48     
- Misses        6878     6909      +31     
- Partials      1265     1285      +20     
Files with missing lines Coverage Δ
...nternal/recorder/mapper/CheckableTextViewMapper.kt 60.00% <100.00%> (-1.82%) ⬇️
...lay/internal/recorder/mapper/SwitchCompatMapper.kt 92.45% <100.00%> (ø)
...ternal/recorder/mapper/CheckableWireframeMapper.kt 86.67% <33.33%> (-13.33%) ⬇️

... and 22 files with indirect coverage changes

@ambushwork ambushwork marked this pull request as ready for review October 24, 2024 15:00
@ambushwork ambushwork requested review from a team as code owners October 24, 2024 15:00
@ambushwork ambushwork merged commit fe3acdf into develop Oct 24, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/hot-fix/update-checkable-privacy branch October 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants