Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the decompression in SR instrumented tests for API 21 #2341

Conversation

mariusc83
Copy link
Collaborator

What does this PR do?

In our SR instrumented tests we need to decompress the segments intercepted through the MockServer in order to be able to assess them with the expected payloads.
The segments are previously compressed with a deflate alg and we are using an Inflater instance in the SR tests to deflate them.
The Inflater class logic is buggy in the Android API 21 JVM. For some reason the inflater.finished method always returns false having our decompression logic running in an endless loop.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Oct 23, 2024
@mariusc83 mariusc83 requested review from a team as code owners October 23, 2024 14:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (ccbfe18) to head (3f7b09e).
Report is 2 commits behind head on feature/sr-integration-test.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/sr-integration-test    #2341      +/-   ##
===============================================================
+ Coverage                        70.35%   70.37%   +0.01%     
===============================================================
  Files                              739      739              
  Lines                            27562    27562              
  Branches                          4617     4617              
===============================================================
+ Hits                             19391    19395       +4     
- Misses                            6878     6880       +2     
+ Partials                          1293     1287       -6     

see 27 files with indirect coverage changes

@mariusc83 mariusc83 merged commit d13c96a into feature/sr-integration-test Oct 24, 2024
24 checks passed
@mariusc83 mariusc83 deleted the mconstantin/fix-decompression-in-sr-end-to-end-tests branch October 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants