Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sr-integration-test #2340

Merged
merged 14 commits into from
Oct 24, 2024
Merged

Feature/sr-integration-test #2340

merged 14 commits into from
Oct 24, 2024

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

Merge feature branch. sr-integration-test into develop

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork marked this pull request as ready for review October 23, 2024 12:58
@ambushwork ambushwork requested review from a team as code owners October 23, 2024 12:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.35%. Comparing base (c9439b5) to head (06a4c93).
Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
...sessionreplay/utils/LegacyDrawableToColorMapper.kt 24.14% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2340      +/-   ##
===========================================
- Coverage    70.43%   70.35%   -0.08%     
===========================================
  Files          739      739              
  Lines        27538    27564      +26     
  Branches      4616     4619       +3     
===========================================
- Hits         19396    19392       -4     
- Misses        6859     6879      +20     
- Partials      1283     1293      +10     
Files with missing lines Coverage Δ
...sessionreplay/utils/LegacyDrawableToColorMapper.kt 46.51% <24.14%> (-11.82%) ⬇️

... and 28 files with indirect coverage changes

@ambushwork ambushwork merged commit caa2a5d into develop Oct 24, 2024
24 checks passed
@ambushwork ambushwork deleted the feature/sr-integration-test branch October 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants