Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image sample screen for jetpack compose session replay #2320

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ambushwork
Copy link
Contributor

@ambushwork ambushwork commented Oct 11, 2024

What does this PR do?

Add sample screen for jetpack compose to demostrate images components:

  • Image
  • Icon
  • Icon Button
  • AsyncImage (coil)

Motivation

To test jetpack compose session replay support for all types of images.

Demo

Screenshot_20241014_095042

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork marked this pull request as ready for review October 14, 2024 07:54
@ambushwork ambushwork requested review from a team as code owners October 14, 2024 07:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (4f6ed19) to head (c1c2523).
Report is 2 commits behind head on feature/sr_compose.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2320      +/-   ##
======================================================
- Coverage               69.60%   69.57%   -0.03%     
======================================================
  Files                     751      751              
  Lines                   27812    27806       -6     
  Branches                 4746     4745       -1     
======================================================
- Hits                    19357    19345      -12     
- Misses                   7119     7128       +9     
+ Partials                 1336     1333       -3     

see 28 files with indirect coverage changes

@ambushwork ambushwork merged commit a0a5cf8 into feature/sr_compose Oct 14, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/compose/add-image-sample branch October 14, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants