Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5873: Update Session Replay integration test payloads #2318

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ambushwork
Copy link
Contributor

@ambushwork ambushwork commented Oct 10, 2024

What does this PR do?

Updates Session replay integration test payloads by using the same config of emulator as gitlab ci,
and remove all the @ignore for SR tests.

Some other changes:

  • @Ignore is removed but @SdkSuppress is added to ignore the SR instrumented tests on legacy-min-api task, because there is an underlying issue make test block forever.
  • In test activity, toolbar is hidden now, because from API 35, edgeToEdge is enabled by default, which makes top content covered by the toolbar, it can lead different wireframes.

Motivation

RUM-5873

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (f5c1891) to head (7acd741).
Report is 2 commits behind head on feature/sr-integration-test.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/sr-integration-test    #2318      +/-   ##
===============================================================
+ Coverage                        70.35%   70.38%   +0.03%     
===============================================================
  Files                              739      739              
  Lines                            27562    27562              
  Branches                          4617     4617              
===============================================================
+ Hits                             19391    19399       +8     
+ Misses                            6878     6876       -2     
+ Partials                          1293     1287       -6     

see 24 files with indirect coverage changes

@ambushwork ambushwork force-pushed the yl/it/generate-json-payload branch 3 times, most recently from 06fdf24 to 259d644 Compare October 21, 2024 15:50
@ambushwork ambushwork force-pushed the yl/it/generate-json-payload branch 2 times, most recently from 0c90c78 to 4cd5f76 Compare October 23, 2024 07:47
@ambushwork ambushwork marked this pull request as ready for review October 23, 2024 07:53
@ambushwork ambushwork requested review from a team as code owners October 23, 2024 07:53
jonathanmos
jonathanmos previously approved these changes Oct 23, 2024
@ambushwork ambushwork merged commit ccbfe18 into feature/sr-integration-test Oct 23, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/it/generate-json-payload branch October 23, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants