Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpanEventSerializerTest flakiness #2311

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

Forgery will generate attribute key like "id" sometimes, when the attribute is serialised, the key like this will be excluded because it's already declared in the main json structure, which causes test failure.

So in unit test we should exclude them to avoid flakiness

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners October 7, 2024 16:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.33%. Comparing base (4cc5caf) to head (3d85ee1).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2311      +/-   ##
===========================================
+ Coverage    70.31%   70.33%   +0.01%     
===========================================
  Files          736      736              
  Lines        27456    27466      +10     
  Branches      4606     4607       +1     
===========================================
+ Hits         19305    19316      +11     
+ Misses        6862     6860       -2     
- Partials      1289     1290       +1     

see 35 files with indirect coverage changes

@ambushwork ambushwork merged commit 7f8b0d9 into develop Oct 8, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/fix-flaky-test-serialiser branch October 8, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants