Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dash to release version in release script #118

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

duncanpharvey
Copy link
Contributor

@duncanpharvey duncanpharvey commented Jan 12, 2024

What does this PR do?

Adds a dash character - to the release version in the launch script so future release tags are consistent with previous versions.

Motivation

Release tag was created with a different pattern than that of previous versions

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanpharvey duncanpharvey requested a review from a team as a code owner January 12, 2024 18:10
@duncanpharvey duncanpharvey changed the title Adds dash to release version in launch script Adds dash to release version in release script Jan 12, 2024
@duncanista duncanista merged commit 443c298 into main Jan 12, 2024
13 checks passed
@duncanista duncanista deleted the duncan-harvey/release-tag-formatting branch January 12, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants