Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI again #909

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Fix CI again #909

merged 10 commits into from
Feb 16, 2024

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Feb 15, 2024

What does this PR do?

  • Pins rspec-expectations and uri gems to fix compatibility with various legacy versions of Ruby/Chefspec.
  • Makes the Rocky image pretend to be CentOS. A recent change to https://omnitruck.chef.io/install.sh (which is downloaded by kitchen before running the actual test) made Rocky to be recognized as rocky, not el. The script later tries to download file https://omnitruck.chef.io/stable/chef/metadata?v=16.17.4&p=rocky&pv=8&m=x86_64 (rocky is the platform passed to it) - these metadata files don't exist for Rocky for old Chef versions, even though this has been fix for newer versions of Chef as per Omnitruck artifact does not exist for Rocky Linux chef/omnitruck#600
  • Fixes the conditions on when we include the security-agent recipe

@bkabrda bkabrda requested a review from a team as a code owner February 15, 2024 12:33
kitchen.docker.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bkabrda bkabrda merged commit f6aad44 into main Feb 16, 2024
13 checks passed
@bkabrda bkabrda deleted the slavek.kabrda/fix-ci-again branch February 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants