Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yarn] enable node-module linker #49

Merged
merged 4 commits into from
Sep 14, 2023
Merged

[yarn] enable node-module linker #49

merged 4 commits into from
Sep 14, 2023

Conversation

Ayc0
Copy link
Collaborator

@Ayc0 Ayc0 commented Sep 13, 2023 •
edited
Loading

What and why?

yarn oss within this version is broken because of bigint. We could update to yarn 3, but this would require to re-write the plugin for the license

How?

  • Enable node-modules linker
  • Re-run yarn oss
  • Add yarn install before yarn oss in the CI
Before After
image image

@Ayc0 Ayc0 closed this Sep 13, 2023
@Ayc0 Ayc0 deleted the Ayc0/nm branch September 13, 2023 16:16
@Ayc0 Ayc0 restored the Ayc0/nm branch September 13, 2023 16:26
@Ayc0 Ayc0 reopened this Sep 13, 2023
@yoannmoinet yoannmoinet merged commit 8ce5d15 into master Sep 14, 2023
5 checks passed
@yoannmoinet yoannmoinet deleted the Ayc0/nm branch September 14, 2023 07:27
@yoannmoinet yoannmoinet mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoannmoinet yoannmoinet yoannmoinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ayc0 @yoannmoinet