[CLI] Fix create plugin wizard #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- better typing - testing - validation
yoannmoinet
force-pushed
the
yoann/fix-create-plugin-workflow
branch
from
d934170
to
5333b35
Compare
yoannmoinet
changed the title
yoannmoinet
commented
Oct 4, 2024
Comment on lines
6
to
+12
| "module": "CommonJS", | ||
| "moduleResolution": "Node", | ||
| "rootDir": "./", | ||
| "outDir": "./dist" | ||
| "outDir": "./dist", | ||
| "paths": { | ||
| "@dd/tools/*": ["./src/*"], | ||
| "@dd/core/*": ["../core/src/*"] | ||
| } |
There was a problem hiding this comment.
This config is slightly different from the other workspaces because we use ts-node to run the CLI.
I'd love to have the exact same config everywhere, but it bite me a few times already trying to unify this.
Taking me hours every time I try to find a way, always reverting everything in the end.
Open to discuss if you have a very clear vision of it.
elbywan
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
yarn cli create-plugindrifted a bit given we're not using it that much.We need to update/fix it, have it follow current standards and test it to ensure it remains as up to date as possible with the reste of the codebase's growth.
How?