ENH: Add grc structure based on MJA dev #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new hydrological module `grc` - Update `grd` structure image (remove percolation)
|
@pag13, @nghi-truyen, je viens de voir que dans |
pag13
approved these changes
Sep 10, 2024
|
@pag13, @nghi-truyen Ca devrait etre ok comme ca. J'ai préféré garder first and second plutot que delayed branch si c'est ok pour vous. |
nghi-truyen
approved these changes
Sep 10, 2024
|
nikel
On 9/10/24 16:18, Francois Colleoni wrote:
@pag13 <https://github.com/pag13>, @nghi-truyen
<https://github.com/nghi-truyen> Ca devrait etre ok comme ca. J'ai
préféré garder first and second plutot que delayed branch si c'est ok
pour vous.
—
Reply to this email directly, view it on GitHub
<#313 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASXKR3ZM662H5D3VSODYPVDZV35TDAVCNFSM6AAAAABN4753I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQHE3DIMJYG4>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Pierre-André Garambois
Chargé de recherche,
Equipe "Risques Hydrométéorologiques" UMR RECOVER, Inrae, Aix-Marseille Université - Aix-en-Provence, France
Mobile : 06 78 05 14 07
Email ***@***.***
|
|
@maximejay, je te ping si jamais tu veux verifier par rapport à ton PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grcgrdstructure image (remove percolation)Should replace #305