FIX: Check that there is available observed discharge at optimized gauge #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
inoelloc
commented
Feb 23, 2024
inoelloc
commented
- Switch from error to warning the reading of observed dicharge file
- Switch order of check for end_warmup cost_options. It must be done before gauge
- Switch cost_options element order
- Add a raise Error if there is no observed discharge available at any optimized gauge. Only for optimization, will still run in forward_run
- Switch from error to warning the reading of observed dicharge file - Switch order of check for end_warmup cost_options. It must be done before gauge - Switch cost_options element order - Add a raise Error if there is no observed discharge available at any optimized gauge. Only for optimization, will still run in forward_run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.